André Dias
André Dias
Based on discussions with @Hotell around the usefulness/flexibility of a `scale` prop, we will look further with design to understand if the layout should be left to the user to...
Agreed, maybe another approach could be to throw warning on usage of `title` directly in Primer components? We'd still have problems detecting prop drilling for regular JSX elements, but it...
This particular instance was already fixed in https://github.com/github/github/pull/281501 ✅ `SectionHeader` is just a shared component used for the metadata sections.
That and the awareness raised within my team should be more than enough because we own the component in question and the shared component that uses it. My original concern...
> We have some Primer components that use the prop name title; but the title prop in these components does not get used as a semantic title attribute in the...
Thank you @straker! That makes much more sense now.