Christoph Herzog

Results 266 comments of Christoph Herzog

Sorry I dropped the ball here, will get it fixed today.

You can only read the body once, so if you read it you have to send a response. You can do that in eg in `request_filter()` and return `Ok(true)`, which...

Not stale. @xdoardo @ayys , you'll be interested in this as part of the DX effort.

I reckon we can remove this feature for now. Journals have not been used much in a way where this feature would become very useful.

Yeah, I did try that. This config seems to be overwritten on each login. Might be something happening in the greeter.

All looks sensible to me. Only concern: I believe cranelift might be tied to a specific version of the parser. If so, we couldn't freely update it.

If I remember correctly `2.x` changed default serialisation, but it was still possible to be backwards compatible by altering the settings. I'm not sure where we used bincode, but it...

Cranelift may be tied to a version of the parser, so not sure if we can freely update without waiting for Cranelift.

@syrusakbary is this still relevant?

If this change is acceptable, I would appreciate a relatively quick patch release!