jj icon indicating copy to clipboard operation
jj copied to clipboard

feat: Use JJ_LOG instead of RUST_LOG for tracing configuration

Open theduke opened this issue 1 year ago • 6 comments

Prevents clashes when working on other Rust projects.

Closes #4219

theduke avatar Aug 27 '24 18:08 theduke

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 27 '24 18:08 google-cla[bot]

This should probably be documented somewhere, but not sure where the best place is.

theduke avatar Aug 27 '24 19:08 theduke

This should probably be documented somewhere, but not sure where the best place is.

Perhaps docs/contributing.md is the best place we have right now

martinvonz avatar Aug 27 '24 19:08 martinvonz

I think this would be nice to get in before the 0.21 release, which will happen tomorrow. @theduke Can you squash these commits and re-push? If not I'm happy to do so (and retain your authorship!) and refile them myself, since we disallow the "Squash" button on GitHub.

thoughtpolice avatar Sep 03 '24 13:09 thoughtpolice

Hi @theduke. Do you still plan to work on this?

samueltardieu avatar Sep 15 '24 19:09 samueltardieu

Sorry I dropped the ball here, will get it fixed today.

theduke avatar Sep 18 '24 04:09 theduke

Superseded by https://github.com/martinvonz/jj/pull/5112.

arxanas avatar Dec 17 '24 08:12 arxanas