D Tripp
D Tripp
Hi @ivanvc @jmhbnz , I'd like to take this issue.
Hello @jmhbnz. I'd like to take a crack at this one. I'm a new contributor looking for mentorship.
@jmhbnz I made a PR: https://github.com/etcd-io/etcd/pull/17983
@jmhbnz @ivanvc @ahrtr Thank you for guiding me through that first PR. Any suggestions on where I should focus for my next contribution?
> > @jmhbnz @ivanvc @ahrtr Thank you for guiding me through that first PR. Any suggestions on where I should focus for my next contribution? > > Most welcome! For...
Hey Team, Is this issue ready to be closed or does it need further action?
> Hi @thedtripp, it looks like your commit message is wrongly formatted (signed-off-by appears twice). I also suggest co-authoring with the author of the original PR #16902. > > /ok-to-test...
> > Hi @jmhbnz, the original suggestion from [#16902 (review)](https://github.com/etcd-io/etcd/pull/16902#pullrequestreview-1725849250) was to add an integration or e2e case for this functionality. But later in [#16866 (comment)](https://github.com/etcd-io/etcd/issues/16866#issuecomment-2104180883), you refer to it...
Commit https://github.com/etcd-io/etcd/pull/17983/commits/4f029a9fc232c69afe1d3d11cfbf5a111ab31e2c, which set threshold to 300 seconds, resulted in failing tests. I will increase the value and try again.
> Thanks, @thedtripp, this is looking good. I suggest squashing your commits into a single one in preparation for merging this PR. Is it ok to squash the commits with...