Per Larsen

Results 43 comments of Per Larsen

@ijustlovemath I recommend you spend some time familiarizing yourself with the code, maybe stepping through key parts of a minimal input sample in a debugger. I wish we had more...

Could you sketch what the above code would look like using the types from `std::sync::atomic` or `core::sync::atomic`? I'm not sure if you'd use `AtomicPtr`, `AtomicU32`, or both to accomplish the...

> Furthermore, we should run the external tests, ./scripts/test_translator.py tests/ and [immunant/c2rust-testsuite](https://github.com/immunant/c2rust-testsuite) CI inside of cargo test. I think `cargo test` should not run `immunant/c2rust-testsuite` since the latter has complex...

That sounds reasonable. `./scripts/test_translator.py tests/ tests/` has far fewer dependencies, so that should be okay.

@chrysn thanks for this PR. I fixed the CI so if you push the minor changes I recommend, we should be able to get this tested and merged in.

@kkysen Nix support and offline builds are not something we're committed to. Unless, `minicbor` offers a C/C++ API, I'm not sure it is a good replacement. Would adding tinycbor as...

@kkysen I think this is a very reasonable request. Happy to brainstorm with you or review a PR that lifts the requirement to provide `compile_commands.json`. We need to make sure...

@davidMcneil I've fixed the problem that caused Azure pipelines to fail. Can you rebase your PR on top of master?

Correct, David that the github actions fails because of the secret token. I turned off actions on forked PRs for that reason so we can ignore that failure. If Azure...

You are right that this should be handled in `builtins.rs`. I assume the challenge is how to call the intrinsic from Rust. Have you looked at crates such as https://github.com/aweinstock314/llvmint...