c2rust icon indicating copy to clipboard operation
c2rust copied to clipboard

Use raw identifier for reserved keywords

Open davidMcneil opened this issue 4 years ago • 5 comments

Resolves #279

Unfortunately, we cannot use a raw identifier for all keywords see the comment here.

Signed-off-by: David McNeil [email protected]

davidMcneil avatar Sep 14 '20 12:09 davidMcneil

@davidMcneil I've fixed the problem that caused Azure pipelines to fail. Can you rebase your PR on top of master?

thedataking avatar Sep 15 '20 14:09 thedataking

@thedataking I rebased, but it is still failing. It looks like there is a problem reading this token?

davidMcneil avatar Sep 15 '20 15:09 davidMcneil

Correct, David that the github actions fails because of the secret token. I turned off actions on forked PRs for that reason so we can ignore that failure. If Azure Pipelines testing succeeds and Andrei is happy, we can can merge this PR.

thedataking avatar Sep 15 '20 16:09 thedataking

Should be this PR rebased and updated? @davidMcneil

XVilka avatar Oct 13 '22 02:10 XVilka

If I'm reading the code correctly (which I might not be, it is late in the evening) this will not handle the case I ran into where a C file had a name starting with a number:

error: expected identifier, found `3DSP`
  --> c2rust-lib.rs:40:9
   |
40 | pub mod 3DSP;
   |         ^^^^ expected identifier

I'm not sure if that would be a separate PR or should be handled here.

VorpalBlade avatar Feb 13 '23 22:02 VorpalBlade