Khan Winter
Khan Winter
I have the required changes for https://github.com/CodeEditApp/CodeEdit/pull/1949 too. It reduces the required loc for the `AutoCompleteCoordinator` significantly. I'll commit my changes and we can revert if needed.
I'd say this is ready to merge. @FastestMolasses I made changes but I can't request your review on your own pr so if you'd like changes please comment!
I made one last change bringing the suggestion UI element down into CESE. The image and color determination are still up to the API caller, but this makes this component...
Yeah, you can provide a custom `NSSplitView` subclass that can give a custom thickness and color. I'll send you the source to resolve the required changes with this branches changes....
I've opened an issue adding our packages with the package index, but you can still use the package without it being indexed. Just use the URL. I'm not quite sure...
This is looking good to me as long as it's in the feature branch for now. Needs some visibility (user confirms downloading and running tools type stuff) before I think...
Same thought as before, since this is a feature branch we'll need to continue iterating on this but I like the foundation. Still that lint error though.
You're right this was broken on main for a long time. We only recently figured it out, this looks like a good improvement I didn't know this was a thing...
Based on the crash report this looks like it's happening in the `StyledRangeStorage` type in CodeEditSourceEditor, which makes me think it may have been fixed in https://github.com/CodeEditApp/CodeEditSourceEditor/pull/303. I'll loop back...