CodeEdit icon indicating copy to clipboard operation
CodeEdit copied to clipboard

Made Editor Separators Thicker

Open austincondiff opened this issue 7 months ago • 2 comments

Description

Made editor separators thicker by conditionally adding separators to editors depending on its position in the split layout.

Related Issues

  • #2054

Checklist

  • [x] I read and understood the contributing guide as well as the code of conduct
  • [x] The issues this PR addresses are related to each other
  • [x] My changes generate no new warnings
  • [x] My code builds and runs on my machine
  • [x] My changes are all related to the related issue above
  • [x] I documented my code

Screenshots

Before

image

After

image

austincondiff avatar May 29 '25 20:05 austincondiff

A few things to note...

In light mode, colors are incorrect and it looks like this in CodeEdit... image

In Xcode... image

The outer separators are darker than the center separator, and both colors are too light and are incorrect.

@thecoolwinter did however mention that we may not need this workaround of adding outer separators because he may know of a way to override the size and color properties.

austincondiff avatar May 30 '25 14:05 austincondiff

Yeah, you can provide a custom NSSplitView subclass that can give a custom thickness and color. I'll send you the source to resolve the required changes with this branches changes. I just made it provide the custom behavior, I didn't find the correct colors.

Screenshot 2025-05-30 at 9 55 02 AM

Screenshot 2025-05-30 at 10 07 53 AM

thecoolwinter avatar May 30 '25 15:05 thecoolwinter