Aram Dermenjian

Results 24 comments of Aram Dermenjian

The `Build & Test` action seems to be failing, but I can't figure out why. It's stating it's not a git repository, when it clearly is. Not sure how to...

@gmou3 I've gone ahead and fixed the things you wanted.

I hadn't noticed the pull request for some reason. I've added your changes as well and double checked things work nicely. Thanks for that.

> Cool. Personally, I'll need some time to review the more essential parts, while learning about oriented matroids. No worries. Take your time =) If there's anything I can do...

> I opened a new PR with some minor edits. Please have a look. > > I added two `# long time` designations on two very time-consuming tests. Can you...

Ok, since I can't test the new doctest, lemme know if it's still showing up as slow for you. I decreased the dimension by a lot, so it should be...

Yeah, I think it would be nice to know why something fails when testing out different OMs, I like your solution. I'm sure you will already but if `M.is_valid(failure_type=True)` is...

If matroids is doing something, might as well go with that option. So then `certificate=True` is the one that returns `True` or `False` else (by default) we get the warnings...

> I have pushed some changes to [thecaligarmo#4](https://github.com/thecaligarmo/sage/pull/4). I removed the automatic validity check from the `init` method in `oriented_matroid.py` for efficiency's and consistency's sake with the rest of the...

Ok, I fixed my error with your pull request (For future, probably better not to merge `develop` into your pull request as then it shows hundreds of files as changed...