Andréa Machizaud
Andréa Machizaud
@JackBoosY @dg0yt I think I implemented the right split between my port `mdl` and its required build tool `vcpkg-tool-clang7`. I successfully tested it locally however I am struggling to get...
> Pinging @theblackunknown for response. Is work still being done for this PR? Hi @Cheney-W , sorry for the delay. Yes this PR is still in progress, I have not...
> I'm tagging this PR for review with the whole team in our next Thursday meeting (7/7/22). > > We usually don't accept PRs trying to set the compiler used...
> versions/m-/mdl.json(2,): error : While reading versions for port mdl from file: version/m-/mdl.json File declares version `2021.1.2` with SHA: f63c610c21422d2b345b1cf88f6df7b3e1cd1c20 But local port with the same version has a different...
Thanks for you review @Thomas1664 , I have integrated your suggestions.
Is there anything else preventing this PR to be merged ?
Thanks for the detailed review and very good questions @BillyONeal I am away this week and probably couple of next ones after so there will be either no or slow...
> > * find_package(Threads REQUIRED QUITE) This is just bogus? [NVIDIA/MDL-SDK#8](https://github.com/NVIDIA/MDL-SDK/pull/8) > > Upstream merged my fix :). But not in a release yet... I have seen it, well done...
> 4. We would like the name to be mdl-sdk for consistency with upstream and https://repology.org/project/mdl-sdk/ Good observation, I'll incorporate this change in my next change set.
> Check that the generated usage is accurate. mdl provides CMake targets: # this is heuristically generated, and may not be correct find_package(unofficial-mdl CONFIG REQUIRED) target_link_libraries(main PRIVATE unofficial::mdl::mdl_sdk unofficial::mdl::mdl_core) Can...