Akshay Pant

icon location Bengaluru, India

Results 8 comments of Akshay Pant

Fedcurv tutorials for Workflow Interface

@mansishr can you please resolve the conflicts and request for review again?

Modifying the `shard_num` read for templates to indicate that `data_path` flag needs to be passed as an integer

> I think extracting first integer from the string is a dangerous assumption. From my understanding, those data paths (e.g. `data/c1` or `data/collab2`) are not actual locations on disk (beyond...

Add `CollaboratorSerialiser` middleware for serialisation/deserialisation between collaborator and aggregator client

The changes in tests mostly include moving tests between the now appropriate modules and/or renaming them.

Add `CollaboratorSerialiser` middleware for serialisation/deserialisation between collaborator and aggregator client

> To begin with, could you add a "why" section in the PR description? In addition to the obvious encapsulation benefits, what framework capabilities do you expect this refactoring to...

Add option to log tensor_db contents on exit

We can use a signal handler that triggers on exit for both, the aggregator and collaborators, that logs the contents of TensorDB in a file in the workspace's `logs` directory....

Choose a port for aggregator server

@mansishr can you please resolve the conflicts and request for review again?

Parameterize PKI certs location

@mansishr can you please resolve the conflicts and request for review again?

Adaptive Optimizers Fix

@alexey-khorkin can you please resolve the conflicts and request for review again?