Emanuele Panzeri

Results 133 comments of Emanuele Panzeri

@connorhu I see now that a PR was merged into the 1.6.x branch but not into the main one. This might lead to confusion on which is the default branch...

@alquerci upgrading from SF1 to SF2 is impossible, what is doable is to wrap a SF1 application into a SF5|SF6|SF7 application (I am saying that by direct experience) → should...

@tevesm : I would suggest to rebase this to the latest 8.x branch, We will be able then to backport/cherry-pick the change into the 7.x branch later To keep the...

> @thePanz For context, the change already went into 8.x and 7.x: Damn, my bad! missed that! Thanks for the headsup! I can check to provide a fix next week...

@ruflin damn, looks like a case we did not properly check (see also: https://github.com/ruflin/Elastica/pull/1872) Should we: 1. just use the array_values? 2. throw an exception? (and use the https://www.php.net/manual/en/function.array-is-list.php to...

@ruflin I agree that "there is just one way of doing [this]". As the current implementation is buggy when *not* using a list, I would expect projects to already be...

I can have a look @nicolas-grekas @Nyholm

@connorhu would you extract the removal of the Version tag into its own PR? This way we can have a more focused (and reduced) changeset :+1:

> I studied some how-tos and changed my mind. For phpunit testing we will also prefer phar based installs. The composer/script section shows which version is preferred. This can be...

As we only support v7.4 or >= 8.1, we should review the docker image handling and simplify it. What about using the Linux Alpine images, and install.the extensions with APK?...