FriendsOfSymfony1
Fix docker images build to handle old linux distribution
@thePanz it's rebased on master branch and ready to merge.
Now the .docker directory is exactly the same as on https://github.com/FriendsOfSymfony1/symfony1/pull/270
@thirsch @Tybaze @thePanz Build docker images from scratch works : done it on GitHub action
The .docker directory is exactly the same on symfony1 repository on the similar PR. https://github.com/FriendsOfSymfony1/symfony1/pull/270
As we only support v7.4 or >= 8.1, we should review the docker image handling and simplify it.
What about using the Linux Alpine images, and install.the extensions with APK? Another approach would be using mlocati ext installer (which triggers the compiling of the extensions, IIRC)
@thePanz what issues do you see?
Your issues will be tackle with care.
My thinking
There are many ways to do one thing. First make it work, then make it well, then make it fast.
The purpose of this PR was to make the local development environment working. There still need to work with more than one PHP version.
The first patch was done since more than 1 year. I waste a lot of times maintaining it as a side branch. I am going to be psychological tied working on it.
Working on big things does not work, big PR need too much time to review, then are hard to be merged. However, small things, small PR can be merged more easily and frequently. I do not want to make any more changes on this one and others I have done.
@thePanz what issues do you see?
Not sure, I did not mention any issue.. I might not get your question, sorry.
Yes, I noticed that this PR (and the other one for SF¹) is quite old and got a lot of work. This is remarkable the work you did here! This work, and the other PR, helped a lot other devs too to provide fixes and opening PRs in this organisation, and this is geat!
My comment was more towards a next step, where PHP 5.3 can be removed from the docker containers, hopefully reducing the complexity in handling the setup of such versions ofn Linux.
@thePanz yes, we can simplify it, reduce build time and more.
Removing PHP 5.3 does not make a big difference, as I successfully make the alignment of PHP 5.3 docker image interface with overs. See the configuration merge done on docker-compose.
The major impact of removing PHP version for docker is to reduce the build time.
Where improvement exists, there is at least one issue. But if there is no issue, making improvement is useless.
The issue you are talking about is the complexity of the Dockerfile. I do not tackle this one yet, as I focus on make it work.
Other issues are:
- Docker image build time
- [sf1] Slow test suite, almost one hour to run all tests for all versions.
[sf1] Slow test suite, almost one hour to run all tests for all versions.
How much faster would parallel testing be?
[sf1] Slow test suite, almost one hour to run all tests for all versions.
How much faster would parallel testing be?
No faster than the slowest test.
Parallel testing, indeed, is an idea, but it is not supported now.
I will give a try to paratest. I've never used it, I wonder how much faster it is.