Emanuele Panzeri comments

Results 133 comments of


                                            Emanuele Panzeri

ORM\Column with enumType but missing type causes internal error

This has been fixed on Doctrine project See: https://github.com/doctrine/orm/issues/11173

Add :void return to methods

> I would apply this here as well for `initPlugin()`? > > EDIT: You don't have a choice, that's what makes the tests fail. Which means it's necessary in the...

Add :void return to methods

ok to merge this one? WDYT @mkalkbrenner

Update GitHub actions, fix NPMv16 deprecation

Hi @tobias-93 I tried but my got stuck :disappointed: I would need some help here, not sure why that test if failing, looks like the tool is not available or...

Update GitHub actions, fix NPMv16 deprecation

Nice, thank you for following up on this! :+1:

assertCount with remembered values causing false positives

Just upgraded to PHPStan v2.11.1 and got this issue. The same code worked fine with v2.10.7 (this was the previous version I had installed)

Use 'static' as return for fluent interfaces of Facets

Note: the failure is related to https://github.com/solariumphp/solarium/pull/1151, which fixes it Thanks to @thomascorthals

Use 'static' as return for fluent interfaces of Facets

@thomascorthals thanks for your pointer! the set of changes in your PR are quite long, you're right! Did you manually alter them, or used rector-php? I might be in favor...

Use 'static' as return for fluent interfaces of Facets

Thanks @thomascorthals Maybe those changes should be added into a next major branch? WDYT @mkalkbrenner?

Use 'static' as return for fluent interfaces of Facets

> > Do you think it will break something? Not sure, we should test it further IMO > I think he meant upping Solarium to level 2 in its entirety....