Michael Davis comments

Results 843 comments of


                                            Michael Davis

Shift modifier not working/recognised in conjunction with other modifier keys when inside Zellij session

Sorry for the delay @imsnif! I'd like to avoid normalizing the input specifically in the scenario of 'Kitty keyboard protocol is enabled but not the "report alternate keys" part' within...

Spellchecking integration

Nothing's stopping you from continuing to use something else via LSP if you choose. You shouldn't need a language server installed for basic spellchecking (word checking, not grammar) though. In...

Yeah that commit is on my driver branch which has a bunch of other changes. I pushed up another [branch](https://github.com/helix-editor/helix/tree/spellbook) off of master: [commit](https://github.com/helix-editor/helix/commit/794b2bef345dc7474013b1810857aa058434cac1). You'll need a dictionary downloaded into...

Spellchecking integration

I was imagining that there would be diagnostics (same as LSP diagnostics) for misspelled words. They could be at a different or maybe customizable severity which would affect how they're...

Spellchecking integration

I believe that branch should be creating the personal dictionary file for you if you use the `add_word_to_personal_dictionary` command. I should update that branch now that Spellbook has suggestions support...

use human-readable sizes for file size on save/write

They're not quite the same thing and I'd prefer we be exact about it. See https://en.wikipedia.org/wiki/Orders_of_magnitude_(data) and kibibyte vs kilobyte and similar.

Searching for \0 leaks error message into UI

That is an instance of a popup component actually, it isn't leaking: https://github.com/helix-editor/helix/blob/c9d829a26dac81a57f18796308d3806d77d0c439/helix-term/src/ui/mod.rs#L136-L160 I believe this is a theme issue with the default theme or the Text component - it...

`khepri_db`: `function_clause` in `rabbit_federation_exchange_link_sup_sup` on network disconnect

The `rabbit_db_msup` module and its callers will need some updates to handle potential timeouts when interacting with Khepri like in https://github.com/rabbitmq/rabbitmq-server/pull/11785 The changes will probably be trickier for this module...

build glibc into appimage

If you make a PR that changes the release.yml workflow it will trigger a dryrun release. You can open up a draft PR and inspect the outputs. If it doesn't...

[Windows] `move_prev_word_start` results in selection that includes newline char when starting from newline char

Here I believe the problem is that we're looking at characters where we should be looking at grapheme clusters. https://github.com/helix-editor/helix/blob/3b7aaddb1391a9e343877ceadb83a41c95ede33f/helix-core/src/movement.rs#L454-L466 If we're going backwards then we see `\n` first and...