Michael Davis

I ported out the change to move the diagnostic handling from Application to Editor to master in https://github.com/helix-editor/helix/commit/62625eda460c7c5e7cbd76db92d2d141aa2f9650 and rebased this. I dropped a change though in : that was...

For now no - I need to go throgh the spec and sit with the changes for a while and then I'll leave some review. I'd also like @pascalkuthe's review...

Yeah feel free to push/rebase/force-push this branch as you see fit - I only force-pushed to resolve the conflicts and keep it to one commit as you had been doing

There's some extra context in the LSP issue tracker about whether you can support push and pull diagnostics simultaneously https://github.com/microsoft/language-server-protocol/issues/1743. ~It sounds like rust-analyzer's behavior currently is a bug.~ It's...

I ported out the change to refactor the diagnostic provider as an enum and the change to add `DocumentDidOpen` (as well as some others) and gave this branch a rebase:...

Pascal and I can take the branch forward as we find time to work on it. I have some changes locally I was working on to track the ongoing requests...

Also related to that: https://github.com/helix-editor/helix/issues/2894, https://github.com/helix-editor/helix/issues/3901, https://github.com/helix-editor/helix/issues/3383#issuecomment-1210662079

Can you try building from source? The function that crashed was changed in #9647 and shouldn't crash any more. Based on the backtrace I assume deno is sending an invalid...

You'll need at least Rust 1.74 and a C/C++ compiler. The tree-sitter grammars are written in C/C++ so the C/C++ compiler may be the issue

\cc @vv9k what do you think of the changes?