the-maddin
the-maddin
Finished for my part. There is no graphical representation of the campaign tree, nor a separate error checker (apart from saving), but everything else works.
I'm not put off by your comments, any shortness that may have created that impression is due to scarcity of time. I appreciate the help in improving this.
I didn't implement an error checker, so this fix does not apply. I'm using the in-game parsing functions as far as possible, so the bug did not appear. My UI...
I'm doing this particular check when saving the campaign. I'll take another look at FRED's implementation of the error checker, but I do believe that error checking should not be...
@Goober5000 I've itemized the error checks in comments. Now tagged with the same numbers, I've expanded my "live" input validation to prevent the user from giving these kinds of bad...
Having resolved resolved previous change requests as far as I'm currently able to, I'd like to re-request reviews.
AFAIK, jg18 is ok with the current state of the PR. As for @z64555 's last unresolved comment, which I seem to have overlooked, the enum variants are used only...
This enum is nested two classes deep, and private to the outer class, so I never felt it was worth the effort to add another namespace for type safety. It...
Declaring the enum inside a class has exactly the same effect as declaring it inside a namespace. _Outside_ the inner class `BranchData`, the variants are used with that namespace, `BranchData::VARIANT`....