Eric Olkowski

Results 346 comments of Eric Olkowski

Adding the Discussion label to keep this more open for discussion rather than for someone to claim or anything. To be clear, would this be an internal rubric, or something...

I think an internal rubric could be useful, but I'm not entirely sure about having such a rubric be viewable by users going through the curriculum (at least maybe not...

Instead of using each of the different points regex individually in the `awardPoints.regex`, we could create a new variable so that the "main" regex isn't as long: ``` const starRegex......

I'm a bit out of touch with the channels so take my opinion with a grain of salt 😆 But I'm not sure if it'd be worth adding more bloat...

Also a followup to comment chain https://github.com/patternfly/patternfly-react/pull/9574#discussion_r1361107738 We may not want to spread the className to the div internal to ClipboardCopyToggle as we don't seem to really do that for...

@mvollmer I took a look at the commits/PR where this issue was mentioned in Cockpit, and some clarification may help with addressing this. From what I could tell, the warnings...

@mvollmer no worries! > In general, I agree, but I think this bug report here is still valid. Evenif we don't end up doing it in this specific case, it...

Followup created to update examples that are still using deprecated versions: https://github.com/patternfly/patternfly-react/issues/10363

In regards to above, followup created for updating examples: https://github.com/patternfly/patternfly-react/issues/10363

Closing as all subtasks have been completed