Eric Olkowski

Results 346 comments of Eric Olkowski

I'm not entirely sure whether putting those items in a collapsed details element would really deter people from viewing hints/possible answers before making their own attempt. What do you think...

Maybe the self checks could be looked over again and made sure whether users should be checking them after, before, or during their attempt. Some early ones are more "make...

Right now I have this as a discussion so neither moving forward nor anything blocking from doing so, but I don't think there is exactly a surefire solution. If you'd...

@Eduardo06sp just wanted to check in and see if you had any additional comments regarding this discussion?

@MaryangaOdin Thanks for wanting to improve the exercise! It looks like you may have pushed some unintended changes, however. Right now there is a change to the cascade fix file...

When navigating the [composable expandable table example](https://www.patternfly.org/v4/components/table#composable-expandable) via VO, at first I didn't hear any context of a toggle button's expanded state (but I was notified the existence of a...

@tlabaj @mcarrano it might depend whether we intend for the Notification Badge to ever be used without the Notification Drawer (maybe instead of a drawer, the badge links to a...

I suppose in the case of the badge being selected in a tab-like scenario, another prop could be introduced to apply the same styling (or apply "selected" styling that is...

@tlabaj @mcarrano Updated the example descriptions to mention the isExpanded prop. Also updated the prop description to mention the expanded styling as well as it setting the `aria-expanded` attribute.

> Would it be more correct to say "indicate the drawer is expanded?" @mcarrano It's definitely a little trickier here since the badge *does* get the aria-expanded attribute set based...