Eric Olkowski

Results 346 comments of Eric Olkowski

Do you mean the styleguide MD file? And if the other custom rules aren't clear enough we can certainly tweak them, but I think most of them should be pretty...

Ah gotcha. I wouldn't be opposed to some documentation like that. I think this should be tackled as 2 separate issues: 1 to update the error message for TOP001, and...

@Asartea ++ agreed with what you said! @nikitarevenco I'll assign you. And I'll say yeah this can all be put into a single PR. The original PR was only 13...

I do think that at some point including some mention of inline JS could be fruitful - makes users aware of the different ways to use JS + the general...

@crasion528 I don't think we need to explicitly mention there's a third way. Just something like "Identify the 2 primary ways to include JavaScript"

Unless there's any issues that arise from using the flag (like "You can use this flag, but be sure to/keep in mind..."), I don't think it's really necessary to add...

Gonna close this for now as it doesn't really feel like a necessary change still, but willing to reopen if anyone feels strongly about it.

I agree that some restructuring makes sense in those first few sections of the JavaScript course. These aren't my final thoughts, just kinda brainstorming after reading these comments + looking...

@01zulfi I'll take a closer look at that at some point soon. May come down to whether it makes more sense to hold off on any sort of restructuring as...