Thomas Deinhamer

Results 69 comments of Thomas Deinhamer

@offlinehacker offline? ;)

I believe this *may* be possible using `ONBUILD` instructions in the `Dockerfile` but we would have to implement it first, before someone can benefit from it.

@pocketjoso, afaik `critical` creates a temporary local file which is passed to `penthouse` instead of the actual/original address. At least that's what I think is happening. The reasons for this...

@bezoerb I've tested it and the error message changed. ``` { "errorMessage": "net::ERR_FILE_NOT_FOUND at file:///C:/Users/user/AppData/Local/Temp/954492307c4418a290d6d4164df58aef/efc9e528d5ccf06a86532443cd2b4e0f.html", "errorType": "Error", "stackTrace": [ "Error: net::ERR_FILE_NOT_FOUND at file:///C:/Users/user/AppData/Local/Temp/954492307c4418a290d6d4164df58aef/efc9e528d5ccf06a86532443cd2b4e0f.html", " at navigate (C:\\Users\\user\\Projects\\project\\node_modules\\puppeteer-core\\lib\\FrameManager.js:121:37)", " at process._tickCallback...

This also happens when using the default `fontFace` mixin from the same file. I've noticed that various variables in `scss/mixins` are declared multiple times in multiple locations, thus overwriting themselves,...

I think this may rather be a duplicate of #153 and not a Google Fonts API issue.

> It should be pretty simple for someone not familiar with Fontsource's source code to work on since it's editing templates. A quick `git clone` left me to realize it...

> Honestly the biggest hurdle of getting new contributors is that first step 😭 You mean all other hurdles are smaller? 😄 I thought I give it a shot right...

Had a "quick" look at it and imo the issue is "resolvable" (for Sass module usage) only by renaming the duplicated variable names in the `scss` file. This would fix...

@DecliningLotus, had some more time to dig a bit deeper into this. What do you think of this, as a first static draft (using Open Sans as the example font)?...