Takeshi Hagikura

Results 52 comments of Takeshi Hagikura

I checked your PR in my local, looks like the fix is not enough because the original class's (e.g. FrameLayout) measure is called in FlexboxHelper. And it expects the original...

Hi @dlew thanks for filing this issue. By any chance, did you attach the zip file same as the issue #389 ? I thought the project of the attached zip...

Thanks for filing this. The reason why measured results are cached is to reuse the same calculation logic for flexbox for both FlexboxLayout and FlexboxLayoutManager. An individual view from FlexboxLayoutManager...

Hi @martinbonnin, Thanks for the report. I checked your repository, but the activity_main only has a top-level ConstraintLayout. And the app didn't crash when I launched the app. Could you...

I think it's same as #479 is it?

Do you create your own LayoutParams in the adapter of the RecyclerView? If so, it's likely the same cause.

Sorry for the delayed replay.. Thanks for the new commit! Yup, the fix looks like what I intended. But noticed that FlexboxLayoutManager.testDrawDirtyFlexLine_multi_viewTypes_direction_row fails consistently. Haven't spotted what causes the failure,...

Hi @technoir42 Unfortunately it's not possible at this moment. I tried the similar implementation, but realized it needs to access the package private members of the ViewHolder, which aren't exposed....

No it's not a known issue. Do you have a code that can reproduce the issue? Thanks in advance.