flexbox-layout icon indicating copy to clipboard operation
flexbox-layout copied to clipboard

fix strange space at the top when FlexWrap (#522)

Open sheckspir opened this issue 4 years ago • 5 comments

sheckspir avatar Jan 15 '20 01:01 sheckspir

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Jan 15 '20 01:01 googlebot

@googlebot I signed it!

sheckspir avatar Jan 15 '20 02:01 sheckspir

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Jan 15 '20 02:01 googlebot

@thagikura Yes, you was right. It was a bad way to resolve it. I looked on it some more, and I saw, that you change OrientationHelper for a situation, when flexWrap != NOWRAP. It makes sense. Because scrolling, in this case, goes otherways But we have a small problem. FlexboxLayoutManager calculate offset position from leftPadding, but should use topPadding (or bottomPadding for reverse) So I used SubOrientationHelper as you did in method assignFromView(View anchor)

sheckspir avatar Jan 22 '20 14:01 sheckspir

Sorry for the delayed replay..

Thanks for the new commit! Yup, the fix looks like what I intended. But noticed that FlexboxLayoutManager.testDrawDirtyFlexLine_multi_viewTypes_direction_row fails consistently.

Haven't spotted what causes the failure, but is it possible to check on your end, too?

thagikura avatar Feb 10 '20 08:02 thagikura