Thomas Otto

Results 42 comments of Thomas Otto

Delta divides the terminal into two panels and only then starts drawing. The width of these panels is currently always identical, this would have to become user configurable at [side_by_side.rs:55](/dandavison/delta/blob/dd19c974baadae1a1/src/features/side_by_side.rs#L55).

This might be caused by [this terminal-size bug](https://github.com/eminence/terminal-size/issues/25) which in turn is used by `console`. The mentioned git bash shell is [MinGW-w64 / build under MSYS2](https://github.com/git-for-windows/MINGW-packages). Given that `$COLUMNS` is...

Yes, both `console` via `terminal-size` and `crossterm` seem to ultimately use `GetConsoleScreenBufferInfo()` on Windows which returns the fallback-value `(24, 79)` under MSYS2. Can you try #1030 which calls `stty` (this...

That would mean typing a lot characters twice (or knowing your shells `Ctrl-K` / `Ctrl-Y` tricks). What about making delta a wrapper for itself, e.g. `delta --pipe grep -n pattern...

For side-by-side mode there already is `--line-fill-method=spaces` (or `ansi`), but since delta does not take the terminal width into account in unified mode it can't know the number of spaces,...

Indeed, leaving this on the existing master branch is probably best, this way everyone with a cloned delta repo can continue working without resetting the upstream. Also, e.g. [lib.rs](https://lib.rs/crates/git-delta-lib) this...

I agree, that is still sorely missing from the wrapping logic. And this could do a bit more than finding the first transition towards a space (`\w` in a regex,...

Yes, visually it should be clear what delta inserted and what the content itself is. ↴ … Β· etc. are colored differently from the code (unless the syntax highlighting does...

For benchmarking I have done some experimental librarification in #902 and one way forward would be to leave the binary in this `git-delta` crate and have its version number refer...

Speaking of tabs, when replacing them `delta` currently uses a fixed number of spaces. However these replacements must stop at a multiple of the tab width, counted from the start...