Tomislav Grospić

Results 12 comments of Tomislav Grospić

We have working implementation so this is definitely an improvement that we will try to include in the first version of block merge.

@nzpr Can this issue be closed? We now have completely different code then referenced in this issue. Am I missing something?

For now it seems that Mockito cannot give us easier way to test effectful code. Let's keep it on hold until further research.

@dckc `rnode-actions` API is coupled with UI so it's not written to be used for external use. But it makes sense to write more general wrapper with the same functionality.

@ian-bloom is there a way to reproduce the error?

I found out what's the problem. Decimal point can be entered in _number_ textbox which is not valid in Rholang. It must be added additional validation. Thanks for reporting! ![image](https://user-images.githubusercontent.com/5306205/102145300-454a8f80-3e67-11eb-871b-dfdf90dcb679.png)

@dckc here is the initial version of the new _rnode-client-js_ repo with only web related stuff. https://github.com/tgrospic/rnode-client-js-dev-test Testing version of the site is published here. https://tgrospic.github.io/rnode-client-js-dev-test Here is also PR...

I was using latest documentation for Metamask. https://metamask.github.io/metamask-docs/guide/ethereum-provider.html#methods-new-api Request for signature is in Ethereum format defined in EIP-1193. https://eips.ethereum.org/EIPS/eip-1193 https://github.com/ethereum/go-ethereum/wiki/Management-APIs#personal_sign I'm not aware how browser extensions like Metamask can be...

@9rb, @zsluedem Is this still a relevant issue?

I don't think semicolon is problematic as before. With the use of linters and preprocessors for JS the danger part is eliminated. https://standardjs.com/rules.html#semicolons I follow _JavaScript Standard Style_ which has...