Tyler Gregg
Tyler Gregg
Ion 1.1 allows users to define _templates_--reusable data shapes that can be invoked as many times as needed--that expand to zero or more Ion values. This issue builds on #656...
Ion 1.1 allows users to define templates--reusable data shapes that can be invoked as many times as needed--that expand to zero or more Ion values. This issue tracks the implementation...
Support for normalized float 16 values and non-numbers has been added. Support for denormalized values should be added. This may help: http://www.fox-toolkit.org/ftp/fasthalffloatconversion.pdf
Agree on naming conventions, techniques for parameterization and asserting failure, nesting, etc. Document these conventions, then ensure they are applied to existing and new unit tests. Related to #298
IonCursorBinaryTest, IonReaderContinuableCoreBinaryTest, IonReaderContinuableApplicationBinaryTest, and IonReaderContinuableTopLevelBinaryTest should be refactored for improved code reuse and readability by following this [template](https://gist.github.com/tgregg/ba7a908c8407e99201097bce747bf152).
FWIW we now have [`Byte.toUnsignedInt`](https://docs.oracle.com/javase/8/docs/api/java/lang/Byte.html#toUnsignedInt-byte-) available. _Originally posted by @jobarr-amzn in https://github.com/amazon-ion/ion-java/pull/503#discussion_r1284823256_ `(integer & 0xFF)` is used throughout the codebase. We should try cleaning this up using `Byte.toUnsignedInt` and quantify...
> If a maximum buffer size is configured, a handler must also be configured. We should the things that must go together in the interface then, e.g. ```java public final...
In some places we use `_child_count` directly, and in others where we could we instead use `get_child_count()`. What governs the choice? _Originally posted by @jobarr-amzn in https://github.com/amazon-ion/ion-java/pull/557#discussion_r1320162678_
`transitionToLargeSize` is called *only* in `IonContainerLite.nextSize`, and the `call_transition` boolean there is always `true`. `transitionToLargeSize` has only one non-trivial implementation, in `IonStructLite`, and that implementation ignores the input size. If...
> I'm generally a little leery of hand-implementing `hashCode` repeatedly. I'd rather have utility methods that make this signficantly easier, e.g. a variadic function for convenience when hashing multiple fields...