Tom Goodsell
Tom Goodsell
I'm against adding these directly to the resource due to https://github.com/okta/terraform-provider-okta/issues/1202 and the terraform best practices (https://www.terraform.io/plugin/hashicorp-provider-design-principles#resources-should-represent-a-single-api-object). However, I think creating a standalone "link" resource that works generically for all...
Lots of deprecated resources already trying to deal with this, however more strict focus on following the Terraform best practices of having the resources not mix and match various API...
Env Used: ``` export GOOGLEWORKSPACE_IMPERSONATED_USER_EMAIL="" export GOOGLEWORKSPACE_DOMAIN="" export GOOGLEWORKSPACE_CUSTOMER_ID="" export GOOGLEWORKSPACE_CREDENTIALS="$HOME/.googleworkspace/.json" export GOOGLEWORKSPACE_OAUTH_SCOPES="https://www.googleapis.com/auth/admin.directory.group,https://www.googleapis.com/auth/admin.directory.user" ``` Test Results: ``` {21-07-08 13:35}tmps-nb-2168:~/Project_WorkDir/terraform-provider-googleworkspace@scope_env_var thomas.goodsell% make testacc TESTARGS="-run=TestAccResourceGroup_basic" ==> Checking source code against gofmt... ==>...
``` {21-06-30 17:05}tmps-nb-2168:~/Project_WorkDir/terraform-provider-googleworkspace@alias_resource thomas.goodsell% make testacc TESTARGS="-run=TestAccResourceUserAlias_basic" ==> Checking source code against gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test -count=1 $(go list ./...) -v -run=TestAccResourceUserAlias_basic...
Test Results: ``` {21-06-30 17:33}tmps-nb-2168:~/Project_WorkDir/terraform-provider-googleworkspace@alias_resource thomas.goodsell% make testacc TESTARGS="-run=TestAccResourceUserAlias_basic"==> Checking source code against gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test -count=1 $(go list ./...) -v...
Test Update: ``` {21-07-08 10:56}tmps-nb-2168:~/Project_WorkDir/terraform-provider-googleworkspace@alias_resource thomas.goodsell% make testacc TESTARGS="-run=TestAccResourceUserAlias_basic" ==> Checking source code against gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test -count=1 $(go list ./...)...
> There's discussion [here](https://discuss.hashicorp.com/t/cooping-with-parallelism-is-there-a-way-to-prioritise-resource-types/55690) about solving a problem like this using a provider-managed `sync.Mutex`. > > Would that solve the problem without requiring any changes to the schema? > >...
@neodem FYI, the exclusion of `manifest.json` is not a mistake, the current spec for image layouts suggests that the old `manifest.json` becomes embedded in `blobs`, while the OCI spec has...
Related upstream issue: https://github.com/google/go-containerregistry/issues/1756 My investigations so far lend me to an early conclusion that the `tar` reader for images is hardcoded to the "single arch image" style output.
Also see: https://github.com/google/go-containerregistry/issues/1793