Tom Morris

Results 686 comments of Tom Morris

p.s. I had rebased your branch onto `master` so that I could test with the latest code base, but perhaps something get messed up, so I'll retest with an untouched...

Thanks for reporting the problem. Can you please let us know what version of OpenRefine you were using? As a workaround, you should be able to restore the UI with...

> you can see the release number at the bottom left of the screenshot Version 3.9-SNAPSHOT [ebbcba1] Thanks for the catch. I missed it because it was in the greyed...

This doesn't seem like the kind of thing which would be unique to @wetneb 's branch. Does it work correctly in the current product releases? BTW, the protocol for this...

I think it's better to have consistent rules for everyone. Guava and its dependencies is only 3.3MB, so not a big deal in the grand scheme of things. There also...

Actually, looking at the GData extension, it doesn't use Guava at all. It's being pulled in as a transitive dependency of the OpenRefine `main` module which is tagged as `provided`,...

I've done some optimization work on this (and would appreciate additional help from any jQuery pros), but have come to the conclusion that a fundamentally different approach is required. It's...

@wetneb Sorry for the delay. I'll try to review this shortly.

> Based on https://jsperf.com/innerhtml-vs-removechild/15 this can be replaced with > ``` > while (this._elmts.bodyInnerDiv.lastChild) { > this._elmts.bodyInnerDiv.removeChild(this._elmts.bodyInnerDiv.lastChild); > } > ``` That jsperf shows that the proposed update is 30X...