Thiago Farina

Makefile missing compile commands

1

Hi, Looks like Makefile is missing CC commands to actually build the source files. May be it was left out intentionally? Regards,

To create dynamic content? Is there any example with html pages?

No BUCK files to build with buck?

3

Buck has support for C++, so it would be awesome if BUCK files were provided instead of CMake files.

https://github.com/twitter/twemcache/blob/82c5d80e66a3c645b09721b3d78ef3aaf83902a8/src/mc.c#L115

There is no SHA1Data function in sha1.h. I think you meant just SHA1 (https://github.com/clibs/sha1/blob/master/sha1.h#L37).

Mac OS X flags required?

1

There seems to be some flags specific to Mac in the Makefile, like the following: -framework CoreFoundation -framework CoreServices Are they really necessary? The code looks cross-platform otherwise.