Helmut K. C. Tessarek

Results 263 comments of Helmut K. C. Tessarek

@MoritzFago If you want to save bandwidth the best option would be to use ForkAwesome via a CDN. @xuv you need the toolchain to build a custom font. however, maybe...

@orhun it seems that you have to approve the CI for the 2 PRs.

But what I could ascertain from a quick look at the code is that prior to this PR errors were handled gracefully. After this PR rustypaste will panic. Not sure...

What about the occurrences of `PasteType::Url.get_path(&config.server.upload_path).unwrap()`? Isn't it true that these can panic? P.S.: but I also noticed the change from `fs::create_dir_all(paste_type.get_path(&server_config.upload_path))?` to use an expect, which is probably what...

> but those are strictly in tests Oops, once again the gh diff failed me again. all the test headers were not in the code, thus I didn't see that...

I have noticed that the tests fail - in-code and fixtures.

what's up with this PR? The tests fail and it should be merged so that I can work on the fix for files with the same name. Can we get...

> Even the `master` test suite fails locally for me, You are correct. I've opened an issue #253 to track this issue. However, there are only 2 tests failing in...

There is still one test case failing. Not sure why that is when it's ok in git master: https://github.com/orhun/rustypaste/actions/runs/8167143469/job/22327067458#step:5:517 P.S.: I can try running your branch locally and check out...

I ran the tests in your branch several times locally and there was never an error. All tests passed. @orhun any chance you could try the tests in this branch...