Liang Zhang

Roadmap discussion of ElasticJob

8

1. Production Design The current ElasticJob is an distributed job scheduler middleware and support resource management in ElasticJob-Cloud. The new ElasticJob may split the feature into 3 independent modules: Job...

Consider about use TRIGGER queue to handle cron and oneoff schedule

1

The current oneoff schedule is use TRIGGER flag to trigger schedule, and cron just call job executor directly. It is better to keep them consist, refactor cron scheduler to use...

Simplify module folders name

2

There are lots problem for long module folders, just ref #20041 It is better to reduce the length of module folder. I plan to remove the prefix of modules, **but...

DataSourcePropertiesValidator should catch SQLException and ShardingSphereInternalException only

1

Catch exception is not recommended, please investigate the class DataSourcePropertiesValidator, and try to instead of catch exception to SQLException and ShardingSphereInternalException. Just search `// TODO check why catch exception here,...

use recursion to setNextException with chain in classes JDBCBackendTransactionManager and LocalTransactionManager

3

Please use recursion to setNextException with chain, not overlap in classes JDBCBackendTransactionManager and LocalTransactionManager. Just search `// TODO` to find the codes.

Add test case for ShardingSphereURLLoadEngine

3

Please add a new fixture of ShardingSphereURLLoader to finish the test case

Refactor DistSQLExecutor's test cases

13

At present, we use the raw executor to perform assertion on test cases. This approach is not accurate, as it requires manual injection of required dependencies such as database and...

Add more test cases on ShardingSphereDatabase

7

- [ ] 3 static create methods - [ ] containsSchema - [ ] getSchema - [ ] addSchema - [ ] dropSchema - [ ] containsDataSource

Add more details for SchemaMetaDataReviseEngineTest

1

The test coverage are not enough. Please add fixture for MetaDataReviseEntry