Simon Humpohl

Results 15 comments of Simon Humpohl

I'll work on it when I find the time :) The zipf create requires rand 0.8 which changed the `SmallRng` and its seed size on 64bit systems. Would you rather...

Do I understand it correctly, that `mix` and the prefill assume that the keys are unique?

The question is if we need to check correctness at all when doing benchmarking. Currently the tests could fail because there is a very small chance of duplicate keys. >...

One could track the number of succesfull and failed operations and view the operation mixture as a rough target. On a sufficiently large set it should be possible to tune...

How about feature-gating new peripherals in backward compatible releases behind a non-default feature?

Is there already some code in this direction? I started playing around with it and realized that there is no abstraction layer in `smoltcp` that allows utilizing the full hardware...

I additionally defined the representations of CastleRights, Color and Piece because they are used to index into arrays with `get_unchecked` in several places.

My fault, I misremembered that the values are guaranteed. > As in C, discriminant values that are not specified are defined as either 0 (for the first variant) or as...

If you do not mind the revert commit this can be merged.

Then the other question is if you want to keep the `repr(u8)` because the current code does not need it anymore. The only downside is imo that it would be...