Nick Terrell

Results 24 issues of Nick Terrell

https://github.com/facebook/zstd/pull/2783 triggered an internal compiler error in the aarch64 compiler. E.g. this [run](https://app.circleci.com/pipelines/github/facebook/zstd/3169/workflows/214e6e68-b827-468c-b364-0b2d0a619f91/jobs/11255). I haven't been able to fix it, so I've just disabled the test for now. We have...

build issue

Zstd has been getting larger over the years, as we've added features and improved performance. We should take a comprehensive look at code size, and try to optimize our code...

long-term

Test this construction for disabling assertions: ```c #define assert(condition) \ do { \ if (0) { \ (void)(condition); \ } \ } while (0) ``` Additionally, do the same for...

The zstd_common module was added upstream in commit https://github.com/torvalds/linux/commit/637a642f5ca5e850186bb64ac75ebb0f124b458d. But the kernel specific code was inlined into the library. This commit switches it to use the out of line method...

CLA Signed

No fix yet, just trying to debug what is going on.

CLA Signed

`zstd_btultra` performs nearly 2x worse than `zstd_opt` on a edge case file. ``` > seq 100000 999999 > seqs > zstd seqs -b16e19i0 16#seqs : 6300000 -> 321618 (19.59), 15.0...

* v1.5.4 * [x] Deprecate `ZSTD_copyCCtx()` & `ZSTD_copyDCtx()` (PR #3196) * [x] Deprecate advanced streaming functions (https://github.com/facebook/zstd/issues/3405) * v1.5.6 * [x] Move `ZSTD_c_targetCBlockSize` CCtx parameter to stable (PR #3964) *...

long-term
release-blocking

In streaming compression, memory usage is very important. We recently added the capability to split the literals between the output buffer & the dctx. But the size of this buffer...

https://www.internalfb.com/intern/staticdocs/thrift/docs/spec/protocol/data/#map-1 It states that: > Maps contain a variable encoded length followed by the key and value types encoded in a single byte. Next comes the payload which is encoded...

See https://github.com/facebook/zstd/commit/94c102038b81ed89e3b013cb1977496612609f85 Reported-by: @georgthegreat