terenceyak

Purpose of EnsureRank

1

Currently, if you try and to run alice on an example in the [docs](https://github.com/getamis/alice/blob/master/crypto/tss/ecdsa/README.md#implementations), it will already fail when calling `NewDKG` with error `large rank`. The example states: ``` Let...

Potential error in expectEvent.contains

9

For the `expectEvent.contains` function, if we look at the else-if condition https://github.com/OpenZeppelin/openzeppelin-test-helpers/blob/ab4b86771431ce17592d5fb9f0a22ce913127517/src/expectEvent.js#L129-L134 This condition is executed if either `args[key]` or the `value` is a `BN` object. However, the assertion on...