Results 27 comments of tequ

NFTInfo RPC was released by clio 1.0.2 https://github.com/XRPLF/clio/releases/tag/1.0.2

AMM implementation is proposed here. https://github.com/XRPLF/rippled/pull/4294

some bug exists This exchange only allow only one channnel to one websoket connection this PR cannot process this now 【FIXED】

Thank you for advice. I fixed it .

Still need to add some more tests. - [x] Added fields - [x] NFTokenOffer field created in NFTokenMint - [x] offer_id added to meta in NFTokenMint

> Is this ready to review? yes😉

Thanks, @scottschurr! I will check your commit and cherry pick!

The following test works without the second argument, so it may be that the required field, sfNFTokenOffers, is not specified. ```cpp { Json::Value jv = token::cancelOffer(buyer); jv[sfNFTokenOffers.jsonName] = Json::arrayValue; env(jv,...

I checked the comment out and the `env(token::cancelOffer(buyer), ter(temMALFORMED));` line is clearly the cause.

```cpp { Json::Value jv = token::cancelOffer(buyer); jv[sfNFTokenOffers.jsonName] = Json::arrayValue; env(jv, ter(temMALFORMED)); env.close(); BEAST_EXPECT(ownerCount(env, buyer) == 1); } ``` checks for `sfNFTokenOffers` is empty arrays or longer than the maximum length,...