mlir

mlir copied to clipboard

Currently the grammar used for syntax highlighting on github (utils/textmate/mlir.json) is very simple. In particular it skips almost any custom form, doesn't handle snippets too well as it attempts to...

jpienaar

TableGen attribute name get methods on ops?

7

In the custom print and parse methods of ops that have a tablegen description, in several places, the names of the attributes are either hardcoded or 'get' methods for the...

bondhugula

Right now the `arguments` in `spv.module` is defined as https://github.com/tensorflow/mlir/blob/199f41354c2998627f592a969bc5b31b5227a800/include/mlir/Dialect/SPIRV/SPIRVStructureOps.td#L312-L318 Actually for `$capabilities` we should be able to use `TypedArrayAttr` as the kind but still parsing and printing the symbols...

antiagainst

[spirv] Define bit ops

10

We need to have all the bit ops defined in the SPIR-V dialect. See the spec ["3.32.14. Bit Instructions"](https://www.khronos.org/registry/spir-v/specs/unified1/SPIRV.html#_a_id_bit_a_bit_instructions) for the list.

antiagainst

ODS: OptionalAttr doesn't lead to generation of builder method with attribute arguments unspecified

1

I noticed that using OptionalAttr doesn't generate a builder method version that doesn't have the attribute as an argument. I also noticed this comment: https://github.com/tensorflow/mlir/blob/a4b11eba615c87b9253f61d9b66f02839490e12b/include/mlir/Dialect/Linalg/IR/LinalgLibraryOps.td#L240 Is this still a TODO?

bondhugula

As discussed in the [RFC](https://groups.google.com/a/tensorflow.org/forum/#!msg/mlir/mt5foNR-xL4/cKPk03_cAQAJ) it would be great to have a way to express qualified symbols that refer to objects in nested modules (or otherwise nested scopes that carry...

sherhut

Add a method to apply specified patterns alone - only on the matching ops?

2

It doesn't look like there is a way to apply a specific rewrite pattern in isolation, i.e., without triggering folding and dead code elimination everywhere in the op (its regions),...

bondhugula

[spirv] Define cast ops

3

We need to support common cast ops. See the spec ["3.32.11. Conversion Instructions"](https://www.khronos.org/registry/spir-v/specs/unified1/SPIRV.html#_a_id_conversion_a_conversion_instructions) for the list. Right now we can ignore those requiring `Kernel` capability.

antiagainst

Operation interfaces: can't name the interface method same as free function on op

8

With the way tablegen based operation interfaces are generated https://github.com/tensorflow/mlir/blob/master/g3doc/OpDefinitions.md#operation-interfaces it doesn't appear to be possible to use the same name for an interface method and a free function that...

bondhugula

This is a copy paste of this thread from the mailing list, which remained unclarified: https://groups.google.com/a/tensorflow.org/forum/#!searchin/mlir/replaceOp%7Csort:date/mlir/pW8Q8u4qs6Y/M9XSQ_agAgAJ While the DAG rewriting doc provides a good high-level overview, I think it's missing...

bondhugula