mlir icon indicating copy to clipboard operation
mlir copied to clipboard

ODS: OptionalAttr doesn't lead to generation of builder method with attribute arguments unspecified

Open bondhugula opened this issue 6 years ago • 1 comments

I noticed that using OptionalAttr doesn't generate a builder method version that doesn't have the attribute as an argument. I also noticed this comment: https://github.com/tensorflow/mlir/blob/a4b11eba615c87b9253f61d9b66f02839490e12b/include/mlir/Dialect/Linalg/IR/LinalgLibraryOps.td#L240

Is this still a TODO?

bondhugula avatar Nov 04 '19 07:11 bondhugula

Yes this is a missing feature not yet supported.

antiagainst avatar Nov 04 '19 17:11 antiagainst