Buğrahan Temür

Results 14 comments of Buğrahan Temür

I think the first option is elegant: - we have a separate set of boundaries. This set has a clear meaning: just holding all possible boundary ids. No functions, nothing....

You're right. The intention is to only remove the `do_*_integral_cell_based()` kind of functions, as they have been workarounds around the fact that neighboring data was not accessible. These functions are...

@peterrum just mentioned this issue in #362. I also think that this is a good idea. > I am in particular thinking about PR https://github.com/exadg/exadg/pull/122 and https://github.com/exadg/exadg/pull/148. Here, #148 is...

I'd appreciate a review if you can @nfehn @peterrum :)

@nfehn Your proposed approach sounds quite good, and a separate object implementing the coefficient calculation can be done easily, but I think there is an important point which may have...

I pushed a new design trying to fit into our constraints. Here are some points: - I implemented a new generic `AnalyticalTensorCoefficientFunctionModel` which is templated for the kernels. This object...

As of now, there is a new version of the implementation for the Generalized Laplace operator. In the new implementation, - the kernel and the coefficient calculation is completely decoupled,...

I'm wondering if `std::visit` to get coefficients on `std::variant` in the innermost loop is going to ruin performance as it won't be inlined...

I think this PR is stuck right now between trying to have a use for the generalized Laplace operator, and the features it needs to have due to its original...