Sergey Shepelev

Results 291 comments of Sergey Shepelev

@thomasgoirand could you confirm that new version using `is` comparison works?

@pjwerneck Beware that this fix would break importing a "real" package named `utils` from sys.path.

Yup, there's no doubt the bug exists. It's just entirely unclear what's the cause and, consequently, how to fix it.

Thank you very much @cabrera ! Test case worth a thousand words.

@erickj00001 `except:` is usually error, because it will also catch `SystemExit`, `KeyboardInterrupt`, `GeneratorExit`. Please add your test to patch, it will probably fail in Python3, where meaning of `except:` is...

I said nothing about `except:` in base class. Likely it is not appropriate everywhere except hub and greenthread code. Last time I looked at fixing it, proper syntax broke too...

Clearly there are problems with current code, arguably the biggest one is `class Timeout(BaseException)`. Then `except:` catching things it shouldn't. Sorry for ambiguity. My points are: - (important) since you...

Hello. What is the issue here? Have you found a case where it is not compatible with google parser?

Closing as inactive, feel free to reopen.

Maybe related to this branch https://github.com/eventlet/eventlet/commits/subprocess-413-more https://github.com/eventlet/eventlet/commit/18c889e99360ddf76cdcad42090fd87e481e84fb though it doesn't apply to `TimeoutExpired` and maybe should.