Sergey Shepelev

Results 291 comments of Sergey Shepelev

@Edvaytech I'm not familiar with engineio, but judging by the name, I suppose you should set - ping_interval = max normal time between messages - ping_timeout = 10*RTT (for example...

@Edvaytech typical time between request and response packet sans processing time. It's around `distance / c` plus network load and re-transmission delays. https://en.wikipedia.org/wiki/Round-trip_delay

@Edvaytech are you also sending messages faster than every 120ms?

As much as I understand working of engineio: - ping feature raises timeout because no other message was received so it thinks network doesn't work - maybe you can set...

You can't just make a *variable* public, because that allows accidental or malicious mutation outside of package. Current unit tests check that some agent is allowed on some path. I'm...

> After all, why does the library have these constants? To save memory. Library can't save cpu/time because it needs to prove that incoming text is equivalent to popular constant....

> I can parse prepared strings every time I need those special cases. But I find it non-ideomatic: I need the special value This is where we don't agree yet....

Please show full code related to monkey patch and starting threads and forks.

@tipabu thanks a lot for fix. I'm going to pull remote verification card here. Did you run anything close to real project with this patch?