Jeremy Rodi

Results 30 comments of Jeremy Rodi

The problem lies [here](https://github.com/activerecord-hackery/squeel/blob/master/lib/squeel/adapters/active_record/4.1/relation_extensions.rb#L304). `join.subquery.left.arel` returns a `Arel::SelectManager`, which is not acceptable to Arel. I'm not sure what should be given in its place, though.

I made this modification and it seems to work: ``` Diff --- a/lib/squeel/adapters/active_record/4.1/relation_extensions.rb +++ b/lib/squeel/adapters/active_record/4.1/relation_extensions.rb @@ -301,7 +301,7 @@ module Squeel def build_join_from_subquery(subquery_joins) subquery_joins.map do |join| join.type.new( - Arel::Nodes::TableAlias.new(join.subquery.left.arel, join.subquery.right),...

You would expect the context to change in that example because it's a "context tag" - it's entire behavior is to change the context you're currently running. However, a "conditional...

As a note, when `{{#item:hello?}}{{value}}{{/item:hello?}}` is encountered, it is my understanding that curly emits something like this: `(context item (conditional hello? (component value)))`, meaning that `(component value)` is resolved against...

Maybe you can refer to the previous context by having a `{{..:posted_at}}` syntax. However, with the "macro" `:`, maybe it would be fruitful to have that compile to a separate...

@dasch doing so could lead to an alternative feature: if a tag couldn't be found, pass it on to a method that acts kind of like `method_missing`. I'm not sure...

If it doesn't exist however, it should still error with the original tag.

Yeah, I'd say instead of that just put the class name and have the developer get that information if they want to.

Modified the output to separate `parameters` into `keywords`, `identifier`, and `block`.

That should be it, let me know if there's anything that needs fixing.