Danny Price

Results 42 comments of Danny Price

Hey @steven-murray - you are most welcome to give it a whirl 👍

Agreed that this may be more efficient for many use cases. If you are happy to try a PR please do go ahead. I don't have much/any time over the...

@steven-murray coming to this late, but I have no idea. That error must be coming from astropy Cosmology (not hickle), so I guess the data isn't loading as expected. Did...

@kartographer agreed, but notice there's an errant `np.floor` in the code: ``` In [4]: Time(np.floor(2456789.5), format='jd',scale='utc').strftime("%Y-%m-%d") Out[4]: '2014-05-11' In [4]: Time(2456789.5, format='jd',scale='utc').strftime("%Y-%m-%d") Out[4]: '2014-05-12' In [5]: Time(np.floor(2456789.51), format='jd',scale='utc').strftime("%Y-%m-%d") Out[5]: '2014-05-11'...

Thanks @kartographer , I wasn't sure if there was a motivation for it, as it seemed rather deliberate! I've issued a PR from my branch. The PR #1436 did introduce...

Note: I'm not going to attempt to fix linting issues as I'm clearly cursed 👻 👕

Hi @0xCoto, @davidgardenier is of course the expert, and I was intending to get his input when we get more serious about simulations, so please consider below to be of...

This also adds YMW16 via `cosmic_pop.set_dm_mw('ymw16')` (Does not fully do tau and scattering stuff though, only DM in cosmic pop)

Thanks @sjoerd-bouma -- finally merged (sorry this dropped off my radar)!

LGTM! FWIW, I would be happy to merge w/o a perfect test as the masking fraction issue is very strange. I've [just updated](https://github.com/telegraphic/pygdsm/commit/05cbd2c12efbe9c9143b55eb981a702271e971a9) the codecov `CODECOV_TOKEN` secret, so if you...