Allow for an artificial horizon when generating an *Observer sky map.

[David-McKenna]

This adds a kwarg to BaseObserver.generate() to allow for the horizon to be set at above 0 degrees, allowing for only a fraction of the visible sky to be sampled.

Additionally, I have added tests to ensure that only a fraction of the sky is visible, and that the rad/deg convention used by pyephem for the lon/lat values is also respected for the elevation keyword.

[what-the-diff[bot]]

PR Summary

• New attribute added to base_observer The base_observer.py file now includes a new attribute, _horizon_elevation. Additionally, the generate method in this file can now accept an argument for horizon_elevation. This allows elevation information to be taken into consideration when observers generate sky data. There's also a new feature that if horizon_elevation is less than 0, a ValueError is logged.

• Improvements to GSMObserver16 testing Test coverage for the GSMObserver16 class in test_gsm2016.py has been extended. Test instances now attribute different values for horizon_elevation. We also introduced a new assertions step to compare variables d_20deg_horizon and d_20deg2rad_horizon.

• Extensive testing parameters for horizon elevation in gsm_observer In test_gsm_observer.py, there's a new test case addressing scenarios when horizon_elevation is less than 0. This addition enhances the robustness of our codebase by validating edge cases. There is also an expanded list of arguments for the generate method which now tests possible values for horizon_elevation.

• Enhanced functionalities of the LFSMObserver class Test_lfsm.py now includes two new test cases for LFSMObserver class and expanded testing for horizon_elevation parameter. We've introduced similar variables d_20deg_horizon and d_20deg2rad_horizon and corresponding assertion steps for comparison as those added in GSMObserver16.

Overall, this PR provides an important update to sky observation functionalities, allowing for an elevation parameter to be considered, and extends test coverage, making our codebase more robust.

[David-McKenna]

Platform dependent masking fraction? Oh, boy, that's going to be fun to figure out...

[telegraphic]

LGTM! FWIW, I would be happy to merge w/o a perfect test as the masking fraction issue is very strange. I've just updated the codecov CODECOV_TOKEN secret, so if you merge from master it should pass tests. (Also happy to merge w/o that test passing).

[David-McKenna]

I'd like to find some way of making it less flakey -- whether it's by using isclose like you mentioned the other day, or by finding a value that reduces the noise/jitter between platforms (i.e., a high elevation where there is a lower fraction of masked pixels).

I'll hopefully have time to find some kind of resolution for this later this week.

[David-McKenna]

~~While watching the checks execute I thought I might as well highlight that while you're linting with flake8, the errors are actually being ignored by the workflow, I'll see if I can patch that up in a bit.~~

Looks like that's intentional, https://github.com/telegraphic/pygdsm/blob/master/.github/workflows/python-app.yml#L37

[David-McKenna]

Looks like CodeCov is out of action again, but the tests were successful this time

[telegraphic]

Hi @David-McKenna -- finally merged! This dropped off my radar, sorry it took so long.

[David-McKenna]

No worries, happy holidays!