Torsten Tejlmand Rasmussen
Torsten Tejlmand Rasmussen
> I'll take a look at the unittest / Kconfig support. Kconfig support is now ready here: #48732 @ahmedmoheb-nordic please try it out for Kconfig settings together with this PR...
> Only thing is that I really would like @cvinayak or @Thalley to take a look at this comment: [#47794 (comment)](https://github.com/zephyrproject-rtos/zephyr/pull/47794#discussion_r958468842) > > so will give a little time for...
@danieldegrasse @mbolivar-nordic @carlescufi @PerMac @jfischer-no all comments addressed, and improved documentation in west build / flash / debug commands wrt. `--domain` has been added. Also added a section of configuration...
> Please take a look and let me know what you think. Thanks a lot. Much better looking, and still contains all the important information.
> Tried adding cmake examples as well for the ones lacking them, however the flash goal can't be used due to it using ninja rather than west for flashing Thanks...
@FrancescoSer thanks for the thorough review, all suggestion applied, but with a little adjustment as described here: https://github.com/zephyrproject-rtos/zephyr/pull/43846#discussion_r939948726
@FrancescoSer feel free to take a new look at the latest changes. I move some text around and added some extra as discussed here: https://github.com/zephyrproject-rtos/zephyr/pull/43846#discussion_r941061998 https://github.com/zephyrproject-rtos/zephyr/pull/43846#discussion_r941062665 Changes: https://github.com/zephyrproject-rtos/zephyr/compare/ebc0d4ad715399d360d40857fec185763eb1701d..403fd33bb7da660cce2824e5f75e439a7b0251ba
> > Please also open an upstream fix for Kconfiglib here: https://github.com/ulfalizer/Kconfiglib > > ulfalizer isn't active so what's the point of submitting to upstream? > That we have tracking...
@ahmedmoheb-nordic cannot add you as reviewer, but please test this PR and give comments.
@ppryga and @thoh-ot this should allow you to cleanup what was in the thread here: https://github.com/zephyrproject-rtos/zephyr/pull/40073#issuecomment-1041451330 Would be great if you can try it out just on a few existing...