maze
maze
...a HttpResponseRedirect for example.
# Bug reports The errors returned by `Prompt.readBuffer` ignores errors returned from `ConsoleParser.Read`, this prevents implementations from exiting gracefully if the underlying transport (`Reader`) disappears. Errors should never go unhandled,...
Please consider using semantic versioning, for the releases and tags, the current dash-based scheme doesn't work well for many packagers. https://semver.org/ Thanks
Not sure how to categorise this, but currently the IMAP client is spewing all kinds of warnings like such: `imap/client: 2016/10/21 17:31:52 response has not been handled: &{* OK HIGHESTMODSEQ...
As reported by @rvantonder, the `bpfink` package currently doesn't pass staticcheck: [SourceGraph query](https://sourcegraph.com/search?q=repo:github%5C.com/bookingcom+lang:go+-file:test+-file:vendor+-file:Godeps+if+strings.ToLower%28...%29+%3D%3D+strings.ToLower%28...%29+or+if+strings.ToLower%28...%29+%21%3D+strings.ToLower%28...%29+or+if+strings.ToUpper%28...%29+%3D%3D+strings.ToUpper%28...%29+or+if+strings.ToUpper%28...%29+%21%3D+strings.ToUpper%28...%29+or+strings.IndexRune%28...%2C+...%29+%3E+-1+or+strings.IndexRune%28...%2C+...%29+%3E%3D+0+or+strings.IndexRune%28...%2C+...%29+%21%3D+-1+or+strings.IndexRune%28...%2C+...%29+%3D%3D+-1+or+strings.IndexRune%28...%2C+...%29+%3C+0+or+strings.IndexAny%28...%2C+...%29+%3E+-1+or+strings.IndexAny%28...%2C+...%29+%3E%3D+0+or+strings.IndexAny%28...%2C+...%29+%21%3D+-1+or+strings.IndexAny%28...%2C+...%29+%3D%3D+-1+or+strings.IndexAny%28...%2C+...%29+%3C+0+or+strings.Index%28...%2C+...%29+%3E+-1+or+strings.Index%28...%2C+...%29+%3E%3D+0+or+strings.Index%28...%2C+...%29+%21%3D+-1+or+strings.Index%28...%2C+...%29+%3D%3D+-1+or+strings.Index%28...%2C+...%29+%3C+0+or+bytes.Compare%28...%2C+...%29+%3D%3D+0+or+bytes.Compare%28...%2C+...%29+%21%3D+0+or+for+:%5B%7E_%5D%2C+:%5B%7E_%5D+%3D+range+or+for+:%5B%7E_%5D+%3D+range+or+for+true+%7B...%7D+or+:%5Bs.%5D%5B:len%28:%5Bs%5D%29%5D+or+time.Now%28%29.Sub%28...%29+or+for+:%5Bi.%5D+:%3D+0%3B+:%5Bi.%5D+%3C+:%5Bn.%5D%3B+:%5Bi.%5D+++%7B++:%5Bbs.%5D%5B:%5Bi%5D%5D+%3D+:%5Bbs.%5D%5B:%5Boffset.%5D+:%5Bi.%5D%5D+%7D+or+make%28...%2C+:%5Bx%5D%2C+:%5Bx%5D%29+or++make%28map%5B:%5B%5Bw%5D%5D%5D:%5B%5Bw%5D%5D%2C+0%29+or+make%28chan+int%2C+0%29+or+if+:%5B_.%5D%2C+ok+:%3D+:%5Bi.%5D.%28:%5BT%5D%29%3B+ok+%26%26+:%5Bi.%5D+%21%3D+nil+%7B+...+%7D+or+if+:%5B_.%5D%2C+ok+:%3D+:%5Bi.%5D.%28:%5BT%5D%29%3B+:%5Bi.%5D+%21%3D+nil+%26%26+ok+%7B+...+%7D+or+if+:%5Bi.%5D+%21%3D+nil+%7B+++if+:%5B_.%5D%2C+ok+:%3D+:%5Bi.%5D.%28:%5BT%5D%29%3B+ok+%7B+...+%7D+%7D+or+func+:%5Bfn.%5D%28...%29+%7B...+return+%7D++or++func%28%29+%7B...+return+%7D+or+.Sub%28time.Now%28%29%29+or+fmt.Println%28%22%25s%22%2C+%22...%22%29+or+errors.New%28fmt.Sprintf%28...%29%29+or+for+:%5B%7E_%5D%2C+:%5B_.%5D+:%3D+range+%5B%5Drune%28...%29+or+sort.Sort%28sort.IntSlice%28...%29%29+or+sort.Sort%28sort.Float64Slice%28...%29%29+or+sort.Sort%28sort.StringSlice%28...%29%29+or+headers.Add%28http.CanonicalHeaderKey%28...%29%2C+...%29+or+headers.Del%28http.CanonicalHeaderKey%28...%29%29+or+headers.Get%28http.CanonicalHeaderKey%28...%29%29+or+headers.Set%28http.CanonicalHeaderKey%28...%29%2C+...%29+or+if+:%5B%7E_%5D%2C+ok+:%3D+:%5Bm.%5D%5B:%5Bk%5D%5D%3B+ok+%7B++++:%5Bm.%5D%5B:%5Bk%5D%5D+%2B%3D+:%5Bx.%5D+%7D+else+%7B++++:%5Bm.%5D%5B:%5Bk%5D%5D+%3D+:%5Bx.%5D+%7D+or+if+:%5B%7E_%5D%2C+ok+:%3D+:%5Bm.%5D%5B:%5Bk%5D%5D%3B+ok+%7B++++:%5Bm.%5D%5B:%5Bk%5D%5D%2B%2B+%7D+else+%7B++++:%5Bm.%5D%5B:%5Bk%5D%5D+%3D+1+%7D+or+if+:%5B%7E_%5D%2C+ok+:%3D+:%5Bm.%5D%5B:%5Bk%5D%5D%3B+ok+%7B%09:%5Bm.%5D%5B:%5Bk%5D%5D+%3D+append%28:%5Bm.%5D%5B:%5Bk%5D%5D%2C+%22:%5Bv1%5D%22%29+%7D+else+%7B+%09:%5Bm.%5D%5B:%5Bk%5D%5D+%3D+%5B%5Dstring%7B%22:%5Bv1%5D%22%7D+%7D+or+if+:%5B%7E_%5D%2C+ok+:%3D+:%5Bm.%5D%5B:%5Bk%5D%5D%3B+ok+%7B%09:%5Bm.%5D%5B:%5Bk%5D%5D+%3D+append%28:%5Bm.%5D%5B:%5Bk%5D%5D%2C+%22:%5Bv1%5D%22%2C+%22:%5Bv2%5D%22%29+%7D+else+%7B%09:%5Bm.%5D%5B:%5Bk%5D%5D+%3D+%5B%5Dstring%7B%22:%5Bv1%5D%22%2C+%22:%5Bv2%5D%22%7D+%7D+or+select+%7B%09case+%3C-time.After%280%29:+%7D+or+fmt.Print%28fmt.Sprintf%28%22...%22%2C+...%29%29+or+fmt.Println%28fmt.Sprintf%28%22...%22%2C+...%29%29+or+fmt.Fprint%28nil%2C+fmt.Sprintf%28%22...%22%2C+...%29%29+or+fmt.Fprintln%28nil%2C+fmt.Sprintf%28%22...%22%2C+...%29%29+or+fmt.Sprint%28fmt.Sprintf%28%22...%22%2C+...%29%29+or+fmt.Sprintln%28fmt.Sprintf%28%22...%22%2C+...%29%29+or++fmt.Sprintf%28%22%25s%22%2C+%22...%22%29&patternType=structural). Apart from addressing these findings, we should probably consider adding `staticcheck` to the CI pipelines.