Brian Botha

Results 157 comments of Brian Botha

Digging through the code, `is_established` gets it's value from `self.handshake_completed` which is set at https://github.com/cloudflare/quiche/blob/0b37da1cc564e40749ba650febd40586a4355be4/quiche/src/lib.rs#L6431 This is getting the value from https://github.com/cloudflare/quiche/blob/0b37da1cc564e40749ba650febd40586a4355be4/quiche/src/tls.rs#L784 Acording to https://www.openssl.org/docs/man1.1.1/man3/SSL_in_init.html ``` SSL_in_init() returns 1 if...

Ah, sorry for my misunderstanding, I'm pretty new to this library. If this is intended behaviour then I had a bad assumption about when a connection is considered established. Digging...

That was a part of working on this. I've shifted to focusing on other things for now since this is relatively lower priority.

I think it's still relevant. No direct work has been done to address this. We can handle a node when it's ID has changed but currently we don't really update...

I can't find anything in the design issues. there is src-old/nodes/NodeManager.ts:179 in the old code.

Not strictly needed but is nice to have for testing and should be reasonably quick to implement. I'll add it in.

I think this is the case now. You can start the `NodeManager` and then need to call `syncNodeGraph`. I'd like to extend this to all background functionality in `NodeGraph`. So...

I'm not sure how we could tell if the user is waiting for an output before sending anything. I guess we'd have to use a proxy for that? But do...

Sure, but it's still possible to attempt a read before writing by using promises. The following will attempt a read before writing but not result in a dead lock. ```ts...

Points 2, 3, 5, 6, 7, 8 of this have been addressed by generally and by recent changes in #696. So the only thing really left to address here is...