FBueller

Results 13 comments of FBueller

This was addressed in https://github.com/apple/coremltools/pull/2170 @YifanShenSZ

> @hugovk - yes, this is very helpful. Thank you. I addressed and fixed this issue in https://github.com/apple/coremltools/pull/2170

> @yosun - please provide more information. What is "HUGS"? What link are you referring to? "HUGS" stands (Haskell User's Graphical System) is a Haskell library for working with tensor...

> Thanks @teelrabbit for the proposed fix. We will need to also fix where all those "number to dtype" mapping are used, e.g. [ops.py](https://github.com/apple/coremltools/blob/main/coremltools/converters/mil/frontend/torch/ops.py#L4386) Makes sense. I'll do some testing...

> "number to dtype" mapping are used Made some changes to the occurrences of NUM_TO_TORCH_DTYPE to use "dtype_to_32bit". Can you comfirm if this is what you intended by "number to...

> LGTM! [CI](https://gitlab.com/coremltools1/coremltools/-/commit/9e689c4b87ca4cd70bd751899819197cff2a5a32/pipelines) ✅ Many thanks for contributing to coremltools! ![futurama-philip-fry](https://github.com/apple/coremltools/assets/55339121/055acba9-dfd3-4ba3-9344-5e7e7cdf7d70)

Also this issue should be closed out https://github.com/apple/coremltools/issues/2153#issuecomment-2085832273

Made changes in the following pull request (https://github.com/apple/coremltools/pull/2171). https://pastes.dev/4BCMTrVIqa

> Made changes in the following pull request (#2171). https://pastes.dev/4BCMTrVIqa https://github.com/apple/coremltools/pull/2171#issuecomment-2021590537

This issue should be closed. Related pull request closed https://github.com/apple/coremltools/pull/2171#issuecomment-2085785869 @YifanShenSZ