Yuan-Ming Hsu
Yuan-Ming Hsu
It seems that this is not a bug. For the default regular expression setting for matching TODOs, `/* request TODO` doesn't match the pattern `(//|#|
Related feature request: #233842 I have encountered similar issue.
Hi @legendecas, Thank you so much for your thoughtful reply and for spotting the potential compatibility issue! This is my first contribution to a public, well-known repository, so I greatly...
To prevent a merge conflict, should I wait until #56130 landing then rebase and force push to this branch? Or should I update this now, so you can review it...
@legendecas Thanks for your guidance. Should the Node version be v23.4.0 in the version 5 report version history? By the way, I notice that the example report in `doc/api/report.md`, for...
I think I do something wrong when I try to rebase it. ~~I follow the [steps](https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#step-9-discuss-and-update) but something goes wrong. Maybe it is because I hit Sync fork on my...
Bumped the report version and added the corresponding version history. And have used `REPLACEME` to refer to the unreleased version. @legendecas would you mind taking a look again? Thanks.
Modified as suggested. Thank you!
@legendecas Some of the tests in the ci failed. But I don't understand why my commit caused them to fail. Do I need to modify anything? Thank you.