techmetx11

Me neither, I left it there for compatibility, but maybe it'll be better if I remove it

> We are no library :) So don't need to worry about compatibility in the regard of not renaming/removing functions. > > I'll have to check the code later. Did...

> If all the functions that use `call_external` work you can actually remove `call_external_sync`, no need to keep it. I removed it now :3

> Did you also test the functionality which calls this function? > > And since it's now two commits about one change you can squash it into one. I've tried...

> Doesn't happen to me and neither to @mdosch. Which executable did you set? So I can test with that one. `firefox`, but make sure that Firefox isn't running already,...

> So to clarify: if people use `xdg-open` everything works fine. If they call their browser directly (ie via setting `/executable urlopen set "chromium %u"`) we get this behaviour. `xdg-open`...

> I tried out requesting vcards and this are my findings: > > * `/vcard get` does autocompletion through occupants in a MUC but not through roster in the main...

> First review looks good! Thanks for your work! I added some comments/questions. > > Also: Did you test the new functionality with valgrind to check for any leaks? It's...

Weird, it compiled fine for me

> ``` > src/xmpp/vcard.c: In function '_vcard_photo_result': > src/xmpp/vcard.c:1374:18: error: too many arguments to function 'call_external' > ``` Oh, I forgot Sorry my bad :3