Tom Rees-Herdman

Results 188 comments of Tom Rees-Herdman

Hi @mohitwp, thanks for your comment. To answer your questions: Q1) Yes, it is acceptable for the layout to shift if the widget encounters errors. We have to choose a...

Thanks @aaemnnosttv, good spot there. I have raised a followup PR, #6097.

Have checked that workflows run successfully having merged this to `develop`. ![image](https://user-images.githubusercontent.com/18395600/196987722-ffd023ae-c6eb-4686-b732-db5001e7f737.png) Also drilled into them to verify they fully ran e.g. ![image](https://user-images.githubusercontent.com/18395600/196988351-1061c107-c7ba-4ca7-8625-01a91100acb9.png) ![image](https://user-images.githubusercontent.com/18395600/196988442-d8f22168-f466-46ea-a304-f3682e1d50cf.png)

Hi @nfmohit, I have a couple of comments on the IB. Looking at the questions as they now stand in Figma: 1. What is the main purpose of this site?...

Thanks @nfmohit, LGTM! IB :white_check_mark:

IB :white_check_mark: @nfmohit I made a minor adjustment and fixed a typo which you can see in the edit history, I didn't think these merited the round trip!

Hi @nfmohit, thanks for the IB. I am not sure about this point: - Update the action added to the `googlesitekit_authorize_user` hook so that if `$previous_scopes` is empty, it redirects...